[root]/proposal/myrmidon/src/java/org/apache/antlib/nativelib
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 38 (100.0%) | 181 (100.0%) | 4.7 |
| donaldp | 26 (68.4%) | 146 (80.7%) | 5.6 |
| adammurdoch | 10 (26.3%) | 33 (18.2%) | 3.3 |
| sbailliez | 2 (5.3%) | 2 (1.1%) | 1.0 |
zappity zap
0 lines of code changed in:
Moved a bunch of classes to framework.nativelib:
- Argument
- ArgumentList
- Commandline
- EnvironmentData
- EnvironmentVariable
- Execute
- LoggingExecOutputHandler
4 lines of code changed in:
* Extracted ArgumentList superclass out of Commandline. Changed most usages
of Commandline to use ArgumentList instead.
* Execute now extends Commandline.
- Removed Execute.getCommandline().
- Moved Commandline.getCommandline() down to Execute, and made private.
12 lines of code changed in:
final static --> static final to follow JLS recomendations
1 lines of code changed in:
Move OsCondition to nativelib package
0 lines of code changed in:
task:name --> task.name
2 lines of code changed in:
More refactoring of framework.Execute:
* By default, execute() checks the return code of the process against 0.
This can be changed using setReturnCode() and setIgnoreReturnCode().
* Default working directory is now the project's base directory.
* Tidied up tasks to reflect the new defaults.
AbstractTask:
* Made getBaseDirectory() and getService() protected.
Logging:
* Extracted AbstractLogger out of BasicLogger, and changed RoutingLogger to
extend AbstractLogger, rather than BasicLogger.
* RoutingLogger now uses a wrapped Logger to determine which message types
are enabled, so that it respects the logging level set on the command-line.
Kinda hacky, but better than writing out all the debug messages.
* Changed LoggingExecOutputHandler to use warn log level, rather than info.
Again, a hacky fix to get logging of external command output happening when
not running in verbose mode.
0 lines of code changed in:
Ran IDEA's optimise imports.
0 lines of code changed in:
Some refactoring of framework.Execute:
* Moved the general-purpose logging and validation code from Exec task to
Execute.
* Removed Execute's constructor, replaced with a TaskContext passed to
Execute.execute().
* If no ExecOutputHandler is provided, Execute routes the process' stdout
and stderr via TaskContext's log methods.
* Removed a bunch of debug messages from tasks, as Execute now takes care of this.
* Replaced a bunch of return code == 0 checks, with calls to
Execute.setReturnCode( 0 ).
8 lines of code changed in:
Move all but the optional tasks into the hierarchy o.a.t.todo rather than o.a.t.ant so as not to clash with ant1 compatability later
4 lines of code changed in:
* AbstractTask no longer extends AbstractLogEnabled.
* DefaultExecutor no longer log enables Tasks.
* Added TaskContext.log( LogLevel, ... ) methods.
* Moved LogLevel to myrmidon.api package.
7 lines of code changed in:
* Added OsFamily enumerated type, to represents OS groupings.
* Replaced all usages of Os.isFamily( String ) with Os.isFamily( OsFamily ).
* Replaced all usages of "os.name" system properties with calls to Os.isFamily().
1 lines of code changed in:
Use getService() to find the ExecManager, rather than instantiating it.
1 lines of code changed in:
Removed throwsIOException from Execute.execute() as it was never thrown.
Made some tasks specify expected return code rather than checkin it themselves.
2 lines of code changed in:
Renamed Execute2 to Execute and moved it into the myrmidon.framework package.
Cleaned up its code a little. ALso reworked it so that the user can specify an expectedReturnCode and if the value is not the one expected a TaskException is thrown.
5 lines of code changed in:
No need to setup a Logger for Execute.
All logging will be routed via System.err or System.out as appropriate
0 lines of code changed in:
Style touchups
1 lines of code changed in:
Add a constructor to Execute2 that takes the ExecManager service
3 lines of code changed in:
Make sure the nativelib tasks declare their tasks so that xdoclet can pick up the meta-data
2 lines of code changed in:
Rework Environment implementation so that it is part of the ExecManager service. This makes it less coupled to bad practices and also merges all the native execution code into a central place.
Detected by JDepend
12 lines of code changed in:
(8 more)
