more efficient check for unescaped qualifier contained within a qualified element.
This new change avoids substring and left trim per Benoit's suggestion.
22 lines of code changed in:
added to the comment about the lTrimKeepTabs
2 lines of code changed in:
renamed IDataSet to DataSet
54 lines of code changed in:
renamed IDataSet to DataSet
310 lines of code changed in:
added test method in that was accidentally removed while combining with bx tests
31 lines of code changed in:
added a couple new checks
2 lines of code changed in:
corrected a couple bugs where the double qualifier replace was not
getting run. Tried to make the look ahead check a little more efficient
preventing the substring and left trim where possible.
11 lines of code changed in:
fixed problem with qualifiers being allowed within the qualified element.
Created a new issue. The check on line 134 of ParserUtilsSplitLineTest
is failing. It seems to me like the check itself may be flawed on the end result.
The parser looks like it is chopping off a " on the end of the element that should
be there.
Benoit, I left a note on what I updated. There is probably a better way
that is going to make for a faster parse.
10 lines of code changed in:
corrected javadoc
1 lines of code changed in:
1 lines of code changed in:
copied over from bx test cases
20 lines of code changed in:
converted to idataset
4 lines of code changed in:
added bx parser
234 lines of code changed in:
removing old code which is replaced by the IDataSet interface
0 lines of code changed in:
moved parser's into ParserUtils
0 lines of code changed in:
removed class which was not really a test
0 lines of code changed in:
added some unit tests for pzconverter
11 lines of code changed in:
moved helper methods into ParserUtils for Object conversion. This
removed some duplicate code and will be easier to unit test
57 lines of code changed in:
- adding some new converter's
- shored up some comments and added license agreement to files
153 lines of code changed in:
added a couple new test with spaces as the delimiter. Removed unused imports
4 lines of code changed in:
put return in catch so it would no longer be empty
1 lines of code changed in:
removed unused import
0 lines of code changed in:
declared final per checkstyle
1 lines of code changed in:
added missing package documentation
26 lines of code changed in:
removed unused import per checkstyle
0 lines of code changed in:
removed default values so checkstyle would not compain about the final
3 lines of code changed in:
Suggestion to use the ObjectLab Kit mail list for announcements (that will increase the audience amongst a few projects)
4 lines of code changed in:
Add link for StatSvn (yep, we've been busy modifying it...)
7 lines of code changed in:
Was a good idea... but it did not work 100%
0 lines of code changed in:
qalab stats
1 lines of code changed in:
added an include for pzconvert.properties
1 lines of code changed in:
logged change
2 lines of code changed in:
first attempt at a new getObject() method in the IDataSet
Benoit, if you get a chance take a look and let me know what
you think of the implementation. I am currently getting some
NPE's in the unit tests. This is because it is not finding
the pzconvert.properties file. I tried to modify the ant script
to make sure it was getting included, but I am having some trouble.
I can take a look at it later and see what the deal is.
Paul
195 lines of code changed in:
added better javadoc comment for stripNonLongChars
6 lines of code changed in:
unit tests to Strip non numeric chars for doubles and longs
52 lines of code changed in:
added a check for demcimal in stripNonLongChars
7 lines of code changed in:
modified performance for strip methods per Benoits suggestions
19 lines of code changed in:
moved code from getInt and getDouble into ParserUtils. Called
methods from ParserUtils
2 lines of code changed in:
added two new methods stripNonDoubleChars() and stripNonLongChars()
removed logic from DefaultDataSet and called these methods instead.
These methods will be usefull in other areas of the code, as we further
develop the API
50 lines of code changed in:
Reverted back to previous revision. Change was not going to work properly.
0 lines of code changed in:
made a change to use the String.split() when no qualifier is
specified. Needs some more testing, seems a little faster.
Going to test against results I got at work yesterday.
8 lines of code changed in: