December 2001 Commit Log

Number of Commits:
409
Number of Active Developers:
9
sbailliez 2001-12-31 20:15

- Add "label" attribute on checkout per request from Greg Frank - checks out a specific view label.

- Add "recursive" attribute as in the deprecated <starteam> task.

- Add "forced" attribute as in the deprecated <starteam> task and avoid checking StarTeam statuses when true.

- Make sure all exceptions are caught on execution and rethrown as build exceptions.

- Fixed a bug (using the "forced" attribute) which were causing files to be incorrectly not checked out when a rootLocalFolder was specified because the StarTeam file statuses were being checked in relation to the default directory.

- Fixed a bug where files were deleted immediately after being checked out when a rootLocalFolder was specified because the task erroneously thought the file was not under starteam control.

- Code layout to fix weird indent issues.



PR: 5583

Submitted by: stevec@ignitesports.com (Steve Cohen)

404 lines of code changed in:

umagesh 2001-12-30 19:53

Removing DestFIle, DestDir, SrcFile, SrcDir, ValidatedFileAttribute and PreferredAttribute.

0 lines of code changed in:

umagesh 2001-12-30 19:49

Removed references to ValidatedFileAttribute and PreferredAttribute.

Reverted IntrospectionHelper to previous version.

4 lines of code changed in:

umagesh 2001-12-30 19:39

Usage of SrcFile,SrcDir,DestFile,DestDir abandoned. Rolling back to

previous state.

53 lines of code changed in:

ehatcher 2001-12-30 14:32

added package mapper as an official mapper type

30 lines of code changed in:

donaldp 2001-12-30 11:13

*** empty log message ***

106 lines of code changed in:

donaldp 2001-12-30 11:10

Move touch into the file package

164 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: Get.java (+1)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/file: Touch.java (new 78)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/i18n: Translate.java (+2 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: Get.java (+1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/file: Touch.java (new 78)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/i18n: Translate.java (+2 -1)
donaldp 2001-12-30 11:10

Move regex replace and support into the text manipulation package

144 lines of code changed in:

donaldp 2001-12-30 11:08

Moved inner classes to top level classes and merged StringUtil into the class that uses it

14 lines of code changed in:

donaldp 2001-12-30 11:00

Begin to cleanup tasks

164 lines of code changed in:

donaldp 2001-12-30 10:46

Restyled.

462 lines of code changed in:

donaldp 2001-12-30 09:58

Move text manipulation tasks into new package

338 lines of code changed in:

donaldp 2001-12-30 09:55

Cleaned up Replace task and broke out inner classes.

126 lines of code changed in:

donaldp 2001-12-30 09:25

Replace all different occurences of grabbing line separator with StringUtil.LINE_SEPARATOR

131 lines of code changed in:

donaldp 2001-12-30 09:15

Remove old BuildListener architecture and replace with ProjectListener

354 lines of code changed in:

donaldp 2001-12-30 09:06

Update scratchpad jar for new parameter in StringUtils

0 lines of code changed in:

donaldp 2001-12-30 08:19

Made into a ProjectListener rather than a BuildListener

20 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional: IContract.java (+10 -29)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional: IContract.java (+10 -29)
donaldp 2001-12-30 08:19

Moved BuildAlert from inner class to top-level class.



Made AntSoundPlayer a ProjectListener rather than a BuildListener

94 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/sound: SoundTask.java (+47 -116)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/sound: SoundTask.java (+47 -116)
donaldp 2001-12-30 08:18

Moved BuildAlert from inner class to top-level class.

0 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/sound: BuildAlert.java (new)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/sound: BuildAlert.java (new)
donaldp 2001-12-30 08:18

Made into a ProjectListener for new style event notification

110 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/sound: AntSoundPlayer.java (+55 -81)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/sound: AntSoundPlayer.java (+55 -81)
donaldp 2001-12-30 07:39

Refactored to work well with new AbstractProjectListener

32 lines of code changed in:

donaldp 2001-12-30 07:39

Cleaned up documentation

4 lines of code changed in:

donaldp 2001-12-30 07:32

Refactor AbstractProjectListener so that it retains state regarding current task and current target

33 lines of code changed in:

donaldp 2001-12-30 06:53

Use simpler isFamily check for netware

1 lines of code changed in:

donaldp 2001-12-30 06:49

Moved implementation of ExecManager into new package

4 lines of code changed in:

donaldp 2001-12-30 06:47

Remove some unused cruft

0 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/myrmidon/framework/exec: Environment.java (-33)
donaldp 2001-12-30 06:46

Made SysProeprties a top level class.

14 lines of code changed in:

donaldp 2001-12-30 06:45

Move implementation of toNativeEnvironment into this class rather than delegating

15 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/myrmidon/framework/exec/launchers: ExecUtil.java (+15 -2)
donaldp 2001-12-30 06:44

Classes not used outside this package so we can make them package access

2 lines of code changed in:

donaldp 2001-12-30 06:36

Remove the initialize and dispose stages in the lifecycle of a task as they no longer are needed given task execution occurs in a single pass.

2 lines of code changed in:

donaldp 2001-12-30 06:35

Remove redundent this.

2 lines of code changed in:

donaldp 2001-12-30 06:28

Parameters object already has an EMPTY_PARAMETRS in it now

0 lines of code changed in:

donaldp 2001-12-30 06:21

No need for task to implement Initializable/Disposable stages because tasks are imediatly executed and there is no concept of multiple passes ala Ant1.x

1 lines of code changed in:

donaldp 2001-12-30 06:17

Check for java 1.4

6 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/myrmidon/framework: JavaVersion.java (+6 -3)
donaldp 2001-12-30 06:14

Move JavaVersion class into framework package

7 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/myrmidon/framework: JavaVersion.java (new 3)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: Javac.java (+1 -1)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional: Javah.java (+1 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: Javac.java (+1 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional: Javah.java (+1 -1)
donaldp 2001-12-30 06:13

Move JavaVersion stuff outside the TaskContext.



JavaVersion is now a completely self-contained class.

43 lines of code changed in:

donaldp 2001-12-30 03:46

Clean some cruft

0 lines of code changed in:

donaldp 2001-12-30 03:44

Only place strings into the BuildEvent

78 lines of code changed in:

donaldp 2001-12-30 03:33

Removed AntClassLoader and replaced it with URLClassLoader. Now new ClassLoaders do not include the ant runtime by default

356 lines of code changed in:

donaldp 2001-12-30 03:30

Remove redundent assignment

2 lines of code changed in:

donaldp 2001-12-30 03:30

Removed some unused logging code.

0 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant: Project.java (-11)
  • proposal/myrmidon/src/todo/org/apache/tools/ant: Project.java (-11)
donaldp 2001-12-30 03:30

Cleaned up class and removed some uneeded (and never working ?) cruft

42 lines of code changed in:

donaldp 2001-12-30 01:26

Rmove more unused cruft from Project

16 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant: Project.java (+5 -187)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: ExecuteJava.java (+1 -1)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional: Script.java (+2 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant: Project.java (+5 -187)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: ExecuteJava.java (+1 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional: Script.java (+2 -1)
donaldp 2001-12-30 01:17

Remove Project.toBoolean

6 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant: Project.java (-14)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/junit: JUnitTestRunner.java (+3 -3)
  • proposal/myrmidon/src/todo/org/apache/tools/ant: Project.java (-14)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/junit: JUnitTestRunner.java (+3 -3)
donaldp 2001-12-30 01:16

Remove those magic proeprties

0 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/compilers: Jikes.java (-35)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/compilers: Jikes.java (-35)
donaldp 2001-12-30 01:14

Removed Project.getVersion() replaced it with getJavaVersion() (inherited from AbstractTask) where necessary and removed all checks for java 1.1

96 lines of code changed in:

donaldp 2001-12-30 01:04

Removed Project.translatePath and replaced it by allowing Files or Path objects be passed in.

36 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant: Project.java (-36)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ccm: Continuus.java (+3 -2)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/clearcase: ClearCase.java (+3 -3)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ejb: DDCreator.java (+3 -3), Ejbc.java (+6 -6)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/vss: MSVSS.java (+3 -2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant: Project.java (-36)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ccm: Continuus.java (+3 -2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/clearcase: ClearCase.java (+3 -3)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ejb: DDCreator.java (+3 -3), Ejbc.java (+6 -6)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/vss: MSVSS.java (+3 -2)
donaldp 2001-12-30 00:54

Made it ignore IDEA projects

1 lines of code changed in:

donaldp 2001-12-30 00:51

Renamed the constants to have constant-y names

14 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/myrmidon/framework: Os.java (+14 -14)
donaldp 2001-12-30 00:50

Removed uneeded property expansion

12 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: Input.java (+1 -1)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/javadoc: Javadoc.java (+5 -17)
  • proposal/myrmidon/src/main/org/apache/tools/ant/types: PatternSet.java (-2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: Input.java (+1 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/javadoc: Javadoc.java (+5 -17)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/types: PatternSet.java (-2)
donaldp 2001-12-30 00:46

Made members private, removed redundently specified "this." and did not try to replace values when adding properties as Ant2 will be fully dynamic

98 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: Property.java (+49 -65)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: Property.java (+49 -65)
donaldp 2001-12-30 00:38

addText() --> addContent()

32 lines of code changed in:

ehatcher 2001-12-30 00:35

made Javadoc provided example more realistic

2 lines of code changed in:

donaldp 2001-12-30 00:33

Echo no longer handles log messages - only useful for writing to files.

4 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: Echo.java (+2 -44)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: Echo.java (+2 -44)
donaldp 2001-12-30 00:30

Remove redundent super() call in constructor

4 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/file: Move.java (+2 -2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/file: Move.java (+2 -2)
donaldp 2001-12-30 00:27

Add a target to help debug the new level enum of log task

10 lines of code changed in:

donaldp 2001-12-30 00:27

Update to make constants conform to proper naming standards

20 lines of code changed in:

donaldp 2001-12-30 00:26

Move DTDLocation inner class to top level class

0 lines of code changed in:

donaldp 2001-12-30 00:26

Update to use getLogger().<method>() rather than log()



Move EchoLevel inner class to top level class

6 lines of code changed in:

donaldp 2001-12-30 00:25

Path no longer takes a project object in the constructor

1 lines of code changed in:

donaldp 2001-12-30 00:25

Update to reflect new LogOutputStream interface

2 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/antlib/cvslib: Cvs.java (+2 -2)
donaldp 2001-12-30 00:24

Update excalibur to fix ClassLoader issue when tasks call back into container with their ContextClassLoader set and the COntainer has yet to load resources. This will then use wrong classloader.



Fixed version will always use the supplied ClassLoader

0 lines of code changed in:

donaldp 2001-12-30 00:21

Update classes so that Path no longer accepts a Project object in its constructor and there is no setProject in ProjectComponent objects

202 lines of code changed in:

ehatcher 2001-12-30 00:21

oops, forgot the license on first pass

54 lines of code changed in:

donaldp 2001-12-30 00:21

Use new format of LogOutputStream

2 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/compilers: Javac12.java (+1 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/compilers: Javac12.java (+1 -1)
donaldp 2001-12-30 00:18

Removed log() method as no classes use it anymore

2 lines of code changed in:

donaldp 2001-12-30 00:17

Moved MapperType inner class to top level class.

0 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/types: MapperType.java (new)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/types: MapperType.java (new)
donaldp 2001-12-30 00:17

Cleaned up Mapper and moved MapperType inner class to top level class.

62 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/types: Mapper.java (+31 -75)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/types: Mapper.java (+31 -75)
ehatcher 2001-12-30 00:17

A new mapper to allow checking <uptodate> from test cases to their XML formatter results.

86 lines of code changed in:

donaldp 2001-12-30 00:16



Move EchoLevel inner class to top level class

0 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: EchoLevel.java (new)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: EchoLevel.java (new)
donaldp 2001-12-30 00:16

Update to use getLogger().<method>() rather than log()



Move EchoLevel inner class to top level class

72 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: Echo.java (+36 -47)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: Echo.java (+36 -47)
donaldp 2001-12-30 00:14

Remove log() statement and replace with getLogger().debug()

2 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: Recorder.java (+1 -2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: Recorder.java (+1 -2)
donaldp 2001-12-30 00:13

Update to use new format of LogOutputStream where you pass in a Logger

4 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: Java.java (+2 -2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: Java.java (+2 -2)
donaldp 2001-12-30 00:12

Remove filtering from rmic task because it didn't make much sense to do filtering there

20 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: Rmic.java (+10 -47)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: Rmic.java (+10 -47)
donaldp 2001-12-30 00:11

made method to create filters protected so it can be used by Move subclass



Removed all notion of setting log level as it is no longer used.

4 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/file: Copy.java (+2 -25)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/file: Copy.java (+2 -25)
donaldp 2001-12-30 00:10

Reuse subclasses method to create filters

4 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/file: Move.java (+2 -18)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/file: Move.java (+2 -18)
donaldp 2001-12-30 00:07

Removed the ability of allowing pluggable log levels.



Refactored creation of filtersets into new method

60 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/file: Move.java (+30 -24)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/file: Move.java (+30 -24)
donaldp 2001-12-30 00:06

Remove deprecated behaviour of using MatchingTask



Removed the ability of allowing pluggable log levels.

140 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/file: Delete.java (+70 -292)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/file: Delete.java (+70 -292)
donaldp 2001-12-30 00:04

Update to use new format of LogOutputStream where you pass in a Logger

186 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: Patch.java (+2 -2)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/compilers: DefaultCompilerAdapter.java (+4 -4)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec: ExecTask.java (+2 -2), Execute.java (+5 -3)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/javadoc: Javadoc.java (+5 -5), JavadocOutputStream.java (+13 -10)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional: ANTLR.java (+2 -2)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/ccm: Continuus.java (+5 -1)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/clearcase: ClearCase.java (+2 -2)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/dotnet: NetCommand.java (+2 -3)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/javacc: JJTree.java (+2 -2)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/jdepend: JDependTask.java (+4 -4)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/junit: JUnitTask.java (+3 -3)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/metamata: MAudit.java (+3 -3), MMetrics.java (+3 -3), MParse.java (+6 -3)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/pvcs: Pvcs.java (+4 -3)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/sitraka: CovMerge.java (+2 -2), CovReport.java (+7 -9), Coverage.java (+9 -7)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/vss: MSVSS.java (+2 -2)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/rmic: SunRmic.java (+2 -1)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/unix: Rpm.java (+4 -4)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: Patch.java (+2 -2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/compilers: DefaultCompilerAdapter.java (+4 -4)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec: ExecTask.java (+2 -2), Execute.java (+5 -3)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/javadoc: Javadoc.java (+5 -5), JavadocOutputStream.java (+13 -10)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional: ANTLR.java (+2 -2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/ccm: Continuus.java (+5 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/clearcase: ClearCase.java (+2 -2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/dotnet: NetCommand.java (+2 -3)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/javacc: JJTree.java (+2 -2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/jdepend: JDependTask.java (+4 -4)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/junit: JUnitTask.java (+3 -3)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/metamata: MAudit.java (+3 -3), MMetrics.java (+3 -3), MParse.java (+6 -3)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/pvcs: Pvcs.java (+4 -3)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/sitraka: CovMerge.java (+2 -2), CovReport.java (+7 -9), Coverage.java (+9 -7)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/vss: MSVSS.java (+2 -2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/rmic: SunRmic.java (+2 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/unix: Rpm.java (+4 -4)
donaldp 2001-12-30 00:03

Update so that LogOutputStream takes a logger and boolean indicating what log level should be logged at.

54 lines of code changed in:

donaldp 2001-12-30 00:01

Pass in streams to constructor rather than task + level. This allows it to be more easily configured for different tasks.

6 lines of code changed in:

donaldp 2001-12-29 23:59

Fix compile error that introduced when moved from Vector to ArrayList

4 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional: NetRexxC.java (+2 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional: NetRexxC.java (+2 -1)
donaldp 2001-12-29 23:48

Move contentEquals method into FixCRLF as it is not used anywhere else

146 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: FixCRLF.java (+70 -1)
  • proposal/myrmidon/src/main/org/apache/tools/ant/util: FileUtils.java (+3 -86)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: FixCRLF.java (+70 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/util: FileUtils.java (+3 -86)
donaldp 2001-12-29 21:55

When a ConverterException occurs then fail convertion and configuration and re-wrap and throw exception

6 lines of code changed in:

donaldp 2001-12-29 21:54

Remove trailing newline

1 lines of code changed in:

donaldp 2001-12-29 21:35

Make sure the error messages are all in resources bundle and are passed appropriate parameters.

6 lines of code changed in:

donaldp 2001-12-29 21:28

Update Log class so that it takes enums to specify the level.

50 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/antlib/core: Log.java (+50 -1)
donaldp 2001-12-29 21:24

A a class to hold enums for the level at which to log.

1 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/antlib/core: LogLevel.java (new 1)
donaldp 2001-12-29 21:18

Add a converter that converts between strings and org.apache.avalon.framework.Enums. It is expected that the Enum class have two public static methods with the following signatures



BlahEnum getByName(String name)

(may return null or throw an IllegalArgumentException if bad name)



String[] getNames()



This is a replacement for EnumeratedAttribute that is more friendly to people who want to use enums programatically.

6 lines of code changed in:

donaldp 2001-12-29 21:13

Make shorter line

3 lines of code changed in:

donaldp 2001-12-29 21:13

Made sure that the MasterConverter verified that the slave converters return the correct type. If not then it will raise an exception.

15 lines of code changed in:

donaldp 2001-12-29 21:07

Made the MasterConverter search through the destination classes hierarchy to find a match for converter. This will allow a converter that converts to a specific superclass also work for all subclasses.

33 lines of code changed in:

donaldp 2001-12-29 21:03

Turned off extreme debugging

1 lines of code changed in:

sbailliez 2001-12-29 20:21

Added additional methods to deal with strings.

This is mostly to avoid the use of regexp for

simple tasks.

100 lines of code changed in:

sbailliez 2001-12-29 19:46

Add an option to append output, I set it to false

to preserve behavior but I think it would be better

to true.

PR: 5559

Reported by: stefanf@decode.is (Stefan Freyr Stefansson)

19 lines of code changed in:

  • docs/manual/CoreTasks: cvs.html (+10 -5)
  • src/main/org/apache/tools/ant/taskdefs: Cvs.java (+9 -2)
umagesh 2001-12-28 21:51

Messages no longer prefix DestDir, DestFile, SrcFile, SrcDir to prevent

providing possibly confusing error messages to user.

23 lines of code changed in:

umagesh 2001-12-28 21:45

setFile(File) deprecated and replaced with setFile(DestFile).



DestFile is used in this case eventhough SrcFile would make more sense

because currently, <property> does not throw an exception if the file

is not found - it just logs a message. If SrcFile were used, it would have

thrown an exception if the file was not found thereby being backwards

incompatible.



<property> was not checking to see if the supplied file was a directory.

It used to throw a java.io.FileNotFoundException previously. Now it

prints a message saying that it is not a file.

38 lines of code changed in:

  • src/main/org/apache/tools/ant/taskdefs: Property.java (+38 -25)
umagesh 2001-12-28 21:25

Selection of PreferredAttributes over 'normal' attributes may break some

tasks that may have overridden setFoo(NormalAttribute).

10 lines of code changed in:

umagesh 2001-12-28 20:27

1. setSrc(File) deprecated and replaced with setSrc(SrcFile)

2. setDest(File) deprecated and replaced with setDest(DestDir)

37 lines of code changed in:

  • src/main/org/apache/tools/ant/taskdefs: Expand.java (+37 -13)
ehatcher 2001-12-28 00:16

fixing incorrectly specified FQCN

2 lines of code changed in:

umagesh 2001-12-27 21:47

Delegate validation to DestDir. This has a nice effect on MkDir as at least

one 'unknown reason' (Path containing an existing non-directory element) will

be known by using DestDir.

16 lines of code changed in:

  • src/main/org/apache/tools/ant/taskdefs: Mkdir.java (+16 -7)
umagesh 2001-12-27 21:31

If DestFile or DestDir does not exist, ensure that the path representing the

directory or the file is valid, by checking if the path contains any existing

non-directory element, thereby making sure the file/dir is constructible.

51 lines of code changed in:

stevel 2001-12-27 05:25

added empty and file constructors, the latter validates as you go. Also a little IsUpToDate() test for destdir which will should simplify dependency checking.

95 lines of code changed in:

stevel 2001-12-27 05:18

using srcFile datatype

12 lines of code changed in:

stevel 2001-12-26 20:37

fixing javadoc tags

4 lines of code changed in:

  • src/main/org/apache/tools/ant/taskdefs/optional/net: TelnetTask.java (+4 -4)
stevel 2001-12-26 20:37

add detail on the nested elements; wrapping a few lines in the process.

35 lines of code changed in:

stevel 2001-12-26 20:35

spello

1 lines of code changed in:

umagesh 2001-12-25 20:07

setFile(File) has been replaced with setFile(SrcFile). No backwards

compatibilty issues here as task was introduced Post 1.4.1.

4 lines of code changed in:

  • src/main/org/apache/tools/ant/taskdefs: Checksum.java (+4 -8)
umagesh 2001-12-25 19:54

setSrc(File) has been replaced with setSrc(SrcFile). No backwards

compatibilty issues here as setSrc(File) was introduced Post 1.4.1.

9 lines of code changed in:

  • src/main/org/apache/tools/ant/taskdefs: Unpack.java (+9 -14)
stevel 2001-12-25 19:52

stops the encoding test failing. We now test that the encoding param is supported, but there is nothing to test that the encoding actually works.

5 lines of code changed in:

umagesh 2001-12-25 19:30

IntrospectionHelper has been modified such that overridden setter methods

that take in 'PreferredAttribute's as argument gain higher precedence.

New attribute types - SrcDir, SrcFile, DestDir and DestFile are introduced. Each of these types is a PreferredAttribute.

41 lines of code changed in:

stevel 2001-12-25 06:15

cvs didnt like the latin-1 stuff

1 lines of code changed in:

stevel 2001-12-25 06:14

new loadfile task

351 lines of code changed in:

ehatcher 2001-12-24 12:05

Modified 'backslash' to be public static final so that the test case can access it. This method is standalone, so having it static is fine.

1 lines of code changed in:

  • src/main/org/apache/tools/ant/taskdefs/optional/perforce: P4Change.java (+1 -1)
stevel 2001-12-24 08:40

new test for nested text element working, PR: 5579

5 lines of code changed in:

  • src/etc/testcases/taskdefs: fail.xml (+5 -1)
stevel 2001-12-24 08:39

test contents of exceptions match expectations

10 lines of code changed in:

  • src/testcases/org/apache/tools/ant/taskdefs: FailTest.java (+10 -2)
stevel 2001-12-24 08:39

PR: 5579 ;fail having uninitialized value trouble.



Which goes to show: if it aint tested, it doesnt work

3 lines of code changed in:

  • src/main/org/apache/tools/ant/taskdefs: Exit.java (+3)
stevel 2001-12-24 03:21

stuck pointers to the mimemail dependencies in here

12 lines of code changed in:

stevel 2001-12-24 03:20

we will have no tabs here!

7 lines of code changed in:

donaldp 2001-12-23 14:25

Start updating logging to myrmidon style logging

1575 lines of code changed in:

donaldp 2001-12-23 07:07

Cleaned up code and gradually moving towards myrmidon patterns

434 lines of code changed in:

donaldp 2001-12-23 07:06

Made GroupArgument a top level class.

2 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/javadoc: GroupArgument.java (new 1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/javadoc: GroupArgument.java (new 1)
donaldp 2001-12-23 06:55

Moved javadoc into package org.apache.tools.ant.taskdefs.javadoc and broken it up to remove all the inner classes.

746 lines of code changed in:

donaldp 2001-12-23 06:35

Fix up license banner.

690 lines of code changed in:

donaldp 2001-12-23 06:28

Fix up license banner.

110 lines of code changed in:

donaldp 2001-12-23 06:22

Add in default implementation of ExecuteManager. It takes over most of the responsibilities of Execute except that it does it in a more easily evolvable manner.

1 lines of code changed in:

donaldp 2001-12-23 06:20

Set the output streams to Execute via setters not via constructor

244 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: Java.java (+10 -8), Javadoc.java (+3 -1), Patch.java (+4 -3)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/compilers: DefaultCompilerAdapter.java (+4 -3)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional: ANTLR.java (+5 -2)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/clearcase: ClearCase.java (+4 -2)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/dotnet: NetCommand.java (+5 -4)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/javacc: JJTree.java (+7 -6)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/jdepend: JDependTask.java (+9 -8)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/junit: JUnitTask.java (+13 -34)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/metamata: AbstractMetamataTask.java (+7 -7), MAudit.java (+10 -6), MMetrics.java (+6 -5)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/perforce: SimpleP4OutputHandler.java (+3 -3)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/pvcs: Pvcs.java (+10 -8)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/sitraka: CovMerge.java (+6 -4), CovReport.java (+6 -4), Coverage.java (-2)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/vss: MSVSS.java (+4 -3)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/unix: Rpm.java (+6 -5)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: Java.java (+10 -8), Javadoc.java (+3 -1), Patch.java (+4 -3)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/compilers: DefaultCompilerAdapter.java (+4 -3)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional: ANTLR.java (+5 -2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/clearcase: ClearCase.java (+4 -2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/dotnet: NetCommand.java (+5 -4)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/javacc: JJTree.java (+7 -6)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/jdepend: JDependTask.java (+9 -8)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/junit: JUnitTask.java (+13 -34)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/metamata: AbstractMetamataTask.java (+7 -7), MAudit.java (+10 -6), MMetrics.java (+6 -5)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/perforce: SimpleP4OutputHandler.java (+3 -3)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/pvcs: Pvcs.java (+10 -8)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/sitraka: CovMerge.java (+6 -4), CovReport.java (+6 -4), Coverage.java (-2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/vss: MSVSS.java (+4 -3)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/unix: Rpm.java (+6 -5)
donaldp 2001-12-23 06:19

Set the output stremes via setters not via constructor



Set timeoout value rather than passing in watchdog

26 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec: ExecTask.java (+13 -25)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec: ExecTask.java (+13 -25)
donaldp 2001-12-23 06:18

Delegate to execute manager rather than doing the work internally.

88 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec: Execute.java (+44 -201)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec: Execute.java (+44 -201)
donaldp 2001-12-23 06:17

Removed some cruft and cleaned up file

52 lines of code changed in:

donaldp 2001-12-23 06:17

Set the output stremes via setters not via constructor

9 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/antlib/cvslib: Cvs.java (+4 -5)
  • proposal/myrmidon/src/java/org/apache/myrmidon/framework/exec: Environment.java (+5 -3)
donaldp 2001-12-23 06:16

No Need to throw a task exception here.

0 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/myrmidon/framework: Os.java (-2)
donaldp 2001-12-23 05:30

add a method to query whether process times out or terminated of natural causes.

9 lines of code changed in:

donaldp 2001-12-23 04:53

Add in class that will replace ExecuteWatchDog, ExeuteStreamHandler and related classes.

0 lines of code changed in:

donaldp 2001-12-23 04:51

Use concreate class LogStreamHandler rather than interface ExeuteStreamHandler

1 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/antlib/cvslib: Cvs.java (+1 -2)
donaldp 2001-12-23 03:42

MOve ProcessDestroyer into myrmidon hierarchy

3 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/myrmidon/framework/exec: ProcessDestroyer.java (new 1)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec: Execute.java (+1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec: Execute.java (+1)
donaldp 2001-12-23 03:40

Fix an error introduced in the Enumeration -> Iterator move

14 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/junit: JUnitTask.java (+7 -6)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/junit: JUnitTask.java (+7 -6)
donaldp 2001-12-23 03:39

We only work with PumpStreamHandler instances so refer to that class in method ratehr than interface.

2 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec: ExecTask.java (+1 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec: ExecTask.java (+1 -1)
donaldp 2001-12-23 03:38

Name cleanup

10 lines of code changed in:

donaldp 2001-12-23 03:38

Make it possible to request shutdown of all pending processes.

54 lines of code changed in:

donaldp 2001-12-23 03:20

Remove failOnError attribute from Exec and thus always fail

8 lines of code changed in:

donaldp 2001-12-23 03:19

Cleaned up Exec code and removed failOnError attribute

204 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec: ExecTask.java (+102 -130)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec: ExecTask.java (+102 -130)
donaldp 2001-12-23 03:17

Add in a rebuild target to make things easier from IDEA

5 lines of code changed in:

donaldp 2001-12-23 02:55

Made ExecMetaData take a Properties object for environment data rather than native format.

40 lines of code changed in:

donaldp 2001-12-23 00:22

Made timeout time a long not an int.

2 lines of code changed in:

donaldp 2001-12-23 00:17

Readded ant1 jar

0 lines of code changed in:

  • proposal/myrmidon/lib: ant.jar (new)
donaldp 2001-12-23 00:16

Remove tools dir from proposal.

4 lines of code changed in:

donaldp 2001-12-23 00:11

Move WatchDog class to myrmidon framework section.

8 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/myrmidon/framework/exec: ExecuteWatchdog.java (new 2)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec: ExecTask.java (+1), Execute.java (+1)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/junit: JUnitTask.java (+1 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec: ExecTask.java (+1), Execute.java (+1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/junit: JUnitTask.java (+1 -1)
donaldp 2001-12-23 00:10

Task never used watchdog so why fake it ?

10 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/jdepend: JDependTask.java (+5 -29)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/jdepend: JDependTask.java (+5 -29)
donaldp 2001-12-22 23:55

Convert from using TaskException to ExecException

174 lines of code changed in:

donaldp 2001-12-22 23:54

Add an exception that indicates an error running a native process.

1 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/myrmidon/framework/exec: ExecException.java (new 1)
donaldp 2001-12-22 23:38

Move unix type tasks into new package

348 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/unix: Chmod.java (new 32), Rpm.java (new 142)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/unix: Chmod.java (new 32), Rpm.java (new 142)
donaldp 2001-12-22 23:35

Made classes use the appropriate execute constructor

22 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: Java.java (+2 -3), Patch.java (+1 -2)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec: Execute.java (+3 -3)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional: ANTLR.java (+1 -1), Rpm.java (+1 -1)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/dotnet: NetCommand.java (+1 -1)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/javacc: JJTree.java (+1 -2)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/perforce: P4Base.java (+1 -2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: Java.java (+2 -3), Patch.java (+1 -2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec: Execute.java (+3 -3)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional: ANTLR.java (+1 -1), Rpm.java (+1 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/dotnet: NetCommand.java (+1 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/javacc: JJTree.java (+1 -2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/perforce: P4Base.java (+1 -2)
donaldp 2001-12-22 23:35

Made class public access while in migration phase.

2 lines of code changed in:

donaldp 2001-12-22 23:11

Add in an interface via which requests to execute a command can be made.

2 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/myrmidon/framework/exec: ExecManager.java (new 2)
donaldp 2001-12-22 23:11

Made EnvironmentData.Variable into a top-level class.

5 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/antlib/cvslib: Cvs.java (+5 -4)
donaldp 2001-12-22 22:59

Removed some unused variables and moved private methods to the bottom of the file

60 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec: Execute.java (+30 -32)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec: Execute.java (+30 -32)
donaldp 2001-12-22 22:53

Continued refactoring

84 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec: Execute.java (+42 -36)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec: Execute.java (+42 -36)
donaldp 2001-12-22 22:52

Setup environment using a properties object

8 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/vss: MSVSS.java (+4 -13)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/vss: MSVSS.java (+4 -13)
donaldp 2001-12-22 22:38

Started to clean up the tasks

232 lines of code changed in:

donaldp 2001-12-22 22:15

Remove Execute.setEnvironment(String[]) as it is not needed.

4 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec: Execute.java (-11)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/vss: MSVSS.java (+2 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec: Execute.java (-11)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/vss: MSVSS.java (+2 -1)
donaldp 2001-12-22 22:14

Remove Execute.getExitValue() as it is not needed.

4 lines of code changed in:

donaldp 2001-12-22 22:01

Moved Commandline.Argument/Marker to top level classes.

110 lines of code changed in:

donaldp 2001-12-22 21:46

Moved ENvironment.Variable to a top level class.

24 lines of code changed in:

donaldp 2001-12-22 21:43

Made EnvironmentData.getVariables return a Properties object with all the environment variables contained within it.

88 lines of code changed in:

donaldp 2001-12-22 13:06

Removed some unused crufty code and moved native ENvironment manipulation code into new class.

162 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec: Execute.java (+81 -206)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec: Execute.java (+81 -206)
donaldp 2001-12-22 13:05

Extract then native Environment manipulation code from Execute class and place it into new class. Refactor it to be simpler to extend and use

51 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/myrmidon/framework/exec: Environment.java (new 51)
donaldp 2001-12-22 13:03

Remove unused import

0 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant: Task.java (-2)
  • proposal/myrmidon/src/todo/org/apache/tools/ant: Task.java (-2)
donaldp 2001-12-22 13:02

Reorder imports.

14 lines of code changed in:

donaldp 2001-12-22 13:00

Cleaned up file a bit and made it package access.

20 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec: StreamPumper.java (+10 -8)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec: StreamPumper.java (+10 -8)
donaldp 2001-12-22 13:00

restyled



Removed setAntRun() calls from Execute class



Renamed Environment to EnvironmentData

220 lines of code changed in:

donaldp 2001-12-22 13:00

load environment data from new Environment class.

48 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: Property.java (+24 -16)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: Property.java (+24 -16)
donaldp 2001-12-22 12:58

restyled

1416 lines of code changed in:

donaldp 2001-12-22 12:54

Rename Environment to EnvironmentData to avoid name conflicts with other classes named Environment

128 lines of code changed in:

donaldp 2001-12-22 12:51

Removed unused import

0 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/condition: Or.java (-1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/condition: Or.java (-1)
donaldp 2001-12-22 12:45

Environment -> EnvironmentData

7 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/antlib/cvslib: Cvs.java (+7 -7)
donaldp 2001-12-22 12:45

access project instance via accessor.

2 lines of code changed in:

donaldp 2001-12-22 12:44

Remove uneeded import

0 lines of code changed in:

donaldp 2001-12-22 12:44

Vector -> ArrayList



access project instance via accessor.

14 lines of code changed in:

donaldp 2001-12-22 12:42

Restyled.

2 lines of code changed in:

donaldp 2001-12-22 12:38

Made it possible for the script to consist of multiple parts so that you could possible do something like



perl bin/antRun.pl

python bin/antRun.py



etc



This resulted in removal of file resolving and pushing that back into the Execute task

32 lines of code changed in:

donaldp 2001-12-22 12:37

Removed uneccesary imports

0 lines of code changed in:

donaldp 2001-12-22 12:36

Move getAntHomeDirectory to the Execute class.

0 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/myrmidon/framework/exec/launchers: ExecUtil.java (-17)
donaldp 2001-12-22 12:36

Removed unecessary import

0 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/myrmidon/framework/exec: ExecMetaData.java (-1)
donaldp 2001-12-22 12:35

Restyled.

484 lines of code changed in:

donaldp 2001-12-22 02:24

Add a document describing some of the features required by a Virtual Filesystem



Submitted by: "Adam Murdoch" <adammurdoch_ml@yahoo.com>

237 lines of code changed in:

sbailliez 2001-12-22 00:10

Don't assume everybody will use the login and pwd to my db.

1 lines of code changed in:

sbailliez 2001-12-22 00:04

This testcase might be used to test for various problems

that may arise when calling the <sql> task multiple

times. I tried to make it easy to customize the test

to run it on different databases.

49 lines of code changed in:

sbailliez 2001-12-22 00:02

Make the getLoaderMap static since the cache is static.

1 lines of code changed in:

  • src/main/org/apache/tools/ant/taskdefs: SQLExec.java (+1 -1)
sbailliez 2001-12-21 22:40

Introduce naive caching of drivers. It is only based on the driver

name while doing pair driver/classpath would be better.

I tested it with mssql and it is OK with 1000 calls.

Alternatively it speeds up things significantly. (about 10 times faster for me)

PR: 2971

Submitted by: stephen.wong@everypath.com

48 lines of code changed in:

  • src/main/org/apache/tools/ant/taskdefs: SQLExec.java (+48 -8)
ehatcher 2001-12-21 22:25

Test of my first commit.



Fixing one more Javadoc HTML error.

1 lines of code changed in:

stevel 2001-12-21 20:08

fixing doc to match code

8 lines of code changed in:

donaldp 2001-12-21 14:21

Move to using Java2 collections API

2728 lines of code changed in:

donaldp 2001-12-21 13:36

Remove execute as inherited from parent

0 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant: Task.java (-13)
  • proposal/myrmidon/src/todo/org/apache/tools/ant: Task.java (-13)
donaldp 2001-12-21 13:34

Encapsulated access to project member variable via getters

376 lines of code changed in:

donaldp 2001-12-21 13:33

Cleaning

32 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/sound: AntSoundPlayer.java (+16 -18)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/optional/sound: AntSoundPlayer.java (+16 -18)
donaldp 2001-12-21 13:29

Make FileUtils static access.

18 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs: FixCRLF.java (+1 -1), Rmic.java (+1 -1)
  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/file: Copy.java (+1 -1), Move.java (+1 -1)
  • proposal/myrmidon/src/main/org/apache/tools/ant/util: FileUtils.java (+5 -15)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs: FixCRLF.java (+1 -1), Rmic.java (+1 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/file: Copy.java (+1 -1), Move.java (+1 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/util: FileUtils.java (+5 -15)
donaldp 2001-12-21 13:28

Remove dependency on StringUtils.

30 lines of code changed in:

donaldp 2001-12-21 13:21

Updated to use the new native command launching infrastructure.

44 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec: Execute.java (+22 -42)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec: Execute.java (+22 -42)
donaldp 2001-12-21 13:20

Converted the old remaining useful script based CommandLaunchers to new setup. There is no need to extend ProxyCommandLauncher as it did not offer any benefit (because the 2 arg version of Runtime.exec was always called)

10 lines of code changed in:

donaldp 2001-12-21 13:19

Converted the old WinNTCommandLauncher to new setup. There is no need to extend ProxyCommandLauncher as it did not offer any benefit (because the 2 arg version of Runtime.exec was always called)

2 lines of code changed in:

donaldp 2001-12-21 13:18

Converted the old MacCommandLauncher to new setup. There is no need to extend ProxyCommandLauncher as it did not offer any benefit (because the 2 arg version of Runtime.exec was always called)

4 lines of code changed in:

donaldp 2001-12-21 13:16

Added a utility class to hold util functions for implementing Launchers.

17 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/myrmidon/framework/exec/launchers: ExecUtil.java (new 17)
donaldp 2001-12-21 13:16

Add a basic implement of CommandLauncher.



This merges the Ant1.x VM launchers into one class. If working on older JVMs (pre jdk1.3) and try to execute outside the current directory then an exception will be thrown.

10 lines of code changed in:

donaldp 2001-12-21 13:12

Add an interface for all CommandLaunchers to implement

3 lines of code changed in:

bodewig 2001-12-21 10:55

If addConfiguredXyz and addXyz (or createXyz) have been present in the

same class, under some conditions, both would be called.



This patch ensures that only the last method returned by the

introspection methods for a given nested element will be used, no

matter which comes last.



Submitted by: Adam Murdoch <adammurdoch_ml@yahoo.com>

2 lines of code changed in:

donaldp 2001-12-21 09:31

Ugly to hack to get it compiling clean

4 lines of code changed in:

sbailliez 2001-12-20 22:36

Remove some newlines to make <pre> content more readable.

0 lines of code changed in:

sbailliez 2001-12-20 21:51

Fixed typo about classnames.

PR: 5448

Submitted by: stevec@ignitesports.com (Steve Cohen)

2 lines of code changed in:

sbailliez 2001-12-20 21:42

Instantiate the document in the constructor so that

an event other than build started does not initiate a NPE.

PR: 5538

Reported by: sh@blsun.com (Scott Halstead)

1 lines of code changed in:

sbailliez 2001-12-19 18:49

Do not forget to exclude new starteams tasks from the build

Submitted by: Peter Janes <peterj@liberate.com>

1 lines of code changed in:

donaldp 2001-12-19 11:52

*** empty log message ***

4 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/file: Delete.java (+2 -1)
  • proposal/myrmidon/src/main/org/apache/tools/ant/types: Environment.java (-1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/file: Delete.java (+2 -1)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/types: Environment.java (-1)
donaldp 2001-12-19 11:50

Move inner classes to top level classes.

136 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/exec: Execute.java (+68 -489)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/exec: Execute.java (+68 -489)
donaldp 2001-12-19 11:50

spruced.

104 lines of code changed in:

donaldp 2001-12-19 11:48

no message

0 lines of code changed in:

donaldp 2001-12-19 11:48

Move command launchers to top level classes. Inner classes are evil.

2 lines of code changed in:

donaldp 2001-12-19 11:33

Start to implement the native execution framework.

4 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/myrmidon/framework/exec: ExecMetaData.java (new 4)
donaldp 2001-12-19 10:40

Made the attributes private and started to break down the methods in tasks to bite size chunks.

448 lines of code changed in:

  • proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/file: Copy.java (+201 -126), Move.java (+23 -24)
  • proposal/myrmidon/src/todo/org/apache/tools/ant/taskdefs/file: Copy.java (+201 -126), Move.java (+23 -24)
donaldp 2001-12-19 10:38

update task list to reflect new package hierarchy

3 lines of code changed in:

donaldp 2001-12-19 10:38

Add some tests for fail and update the taskdef test for new package hierarchy

18 lines of code changed in:

  • proposal/myrmidon/src/make: sample.ant (+18 -1)
donaldp 2001-12-19 10:37

Correct to conform more closely to NoBannerLogger output.

1 lines of code changed in:

donaldp 2001-12-19 10:37

Fix bug where aspect'ized tasks would get null content.

10 lines of code changed in:

donaldp 2001-12-19 10:36

Removed reserved attributes as there is no such thing as setLogger anymore.

12 lines of code changed in:

donaldp 2001-12-19 10:31

Ran style formatter over file.

4 lines of code changed in:

donaldp 2001-12-19 10:30

FailOnError no longer needed.

0 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/antlib/cvslib: Cvs.java (-6)
donaldp 2001-12-19 10:29

Made the shifts into a static variable

2 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/antlib/cvslib: CVSPass.java (+2 -2)
donaldp 2001-12-19 10:29

Fail should not need a condition and will just unconditionally fail if not provided.

7 lines of code changed in:

  • proposal/myrmidon/src/java/org/apache/antlib/core: Fail.java (+7 -7)
sbailliez 2001-12-18 22:18

Major refactoring of Starteam tasks.

This is based on the original submission from the CruiseControl project.

Original <starteam> task has been deprecated

Starteam tasks now resides in the starteam package rather than scm.

Submitted by: stevec@ignitesports.com (Steve Cohen)

1335 lines of code changed in:

sbailliez 2001-12-18 21:27

Fixed jpcovmerge example. It was incorrectly using jpcovreport instead of jpcovmerge

Reported by: scottstirling@rcn.com (Scott Stirling)

2 lines of code changed in:

bodewig 2001-12-18 20:57

Properly encode control characters. See XML 1.0 2.2

<http://www.w3.org/TR/1998/REC-xml-19980210#charsets>.



Submitted by: Jim White <jim@pagesmiths.com>

48 lines of code changed in:

bodewig 2001-12-18 20:19

* addConfigured methods for custom tasks were being called twice. This

problem was caused by RuntimeConfigurable.maybeConfigure() being called

twice on the task's RuntimeConfigurable - once in

UnknownElement.maybeConfigure(), and once in the custom task's perform()

method.



* Whitespace in text content was sometimes being thrown away, depending on

how the SAX parser decided to divide it across calls to

ContentHandler.characters().



Submitted by: Adam Murdoch <adammurdoch_ml@yahoo.com>

13 lines of code changed in:

donaldp 2001-12-17 10:55

MOved file tasks into separate package.

920 lines of code changed in:

donaldp 2001-12-17 10:50

Added a zero arg constructor that contains an empty message.

8 lines of code changed in:

donaldp 2001-12-17 10:50

Start reducing the dependence on FileUtils.

206 lines of code changed in: