Ant is reusing the same helper
PR:
Obtained from:
Submitted by:
Reviewed by:
1 lines of code changed in:
Remove the debug statement.
PR:
Obtained from:
Submitted by:
Reviewed by:
1 lines of code changed in:
Ant will try to copy all inheritedReferences. Some may not exist.
Display a warning.
I don't understand very well the code - but we take the name from
"references" ( which is specified by the user ), and assume that
all of them exist. For some reason that's not allways true.
6 lines of code changed in:
Added back the import property.
Added a small message to allow debugging of duplicated project names.
PR:
Obtained from:
Submitted by:
Reviewed by:
30 lines of code changed in:
Extra check for null.
Input is calling setNewProperty - but if defaultValue and value are null
we'll get NPE
PR:
Obtained from:
Submitted by:
Reviewed by:
3 lines of code changed in:
Weird. UE didn't seem to call setProject on the task. That seems to be
the cause of the NPE.
PR:
Obtained from:
Submitted by:
Reviewed by:
1 lines of code changed in:
still 2002
1 lines of code changed in:
Fix getParent() ( cut&paste from ProjectHelperImpl )
2 lines of code changed in:
Update with the current name generation schema.
There is no standard for how jsp generates names - and jasper
changes from time to time :-)
PR:
Obtained from:
Submitted by:
Reviewed by:
11 lines of code changed in:
Finally fix the jspc test failure.
This is just the first round, it can be improved - not sure what's
the best way to deal with classpath specific issues in path.
The problem is that CLASSPATH ( as given in the system property,
and added in concatSystemPath ) may contain relative paths,
and they are relative to user.dir, not the project basedir.
Since gump is using relative paths, the launched java didn't find
the classes it needed, returning the strange -1 error.
Of course, the test suite could be more informative too :-)
PR:
Obtained from:
Submitted by:
Reviewed by:
25 lines of code changed in:
A small test for xmldom and jxpath.
Seems to work fine for me. Make sure you have commons-jxpath.jar in
ant/lib ( or use <classloader> )
14 lines of code changed in:
Fix the CRLF failure.
The test relies on the order of attributes ( cr set before eol ). Probably
other tasks are in the same situation.
The original change tried to reduce the dependencies on SAX - we may
use DOM or direct API calls in future, and the code will become very
complex. I just used the same thing that SAX is using ( 2 Vectors to
preserve the order ). We could also pick one ( SAX2 attributes ) and use
it in all cases.
PR:
Obtained from:
Submitted by:
Reviewed by:
12 lines of code changed in:
Changed the build system.
embed-optional will build optiona-dynprop.jar containing the dynamic
properties and XMLDOM.
Main will just display a message - the hooks are not needed with ant1.6,
only for ant1.5. ( the component helper is not yet in 1.6, but
it's easier )
7 lines of code changed in:
Include optional-* ( probably don't have to include ant.jar any more for
ant1.6, but still needed with ant1.5 )
4 lines of code changed in:
Same attributes names as in ant1.6
5 lines of code changed in:
Update to the new hook.
It seems to work now :-)
87 lines of code changed in:
Few small changes. If the core loader is set and no explicit classpath
is present, use it.
I think this can be further cleaned up to use the right parent loader
etc. But probably the best would be to just use the loaderRef.
Or just deprecate Definer completely - when we have a good antlib solution
Also added getters ( it's nice to have access to info - especially with
dynamic properties :-)
50 lines of code changed in:
Few fixes, AntClassLoader uses parentFirst, Classloader was using reverse.
Make them consistent
PR:
Obtained from:
Submitted by:
Reviewed by:
19 lines of code changed in:
Add setting support
6 lines of code changed in:
Remove the old helper
0 lines of code changed in:
Update to ProjectHelper
23 lines of code changed in:
Update to the new hook mechanism.
68 lines of code changed in:
Call direcltly project ( all other tasks do this )
PR:
Obtained from:
Submitted by:
Reviewed by:
1 lines of code changed in:
Call project.replaceProperties(). Probably should call PropertyHelper directly,
but Grant ( and others ) may extend project and override it.
PR:
Obtained from:
Submitted by:
Reviewed by:
1 lines of code changed in:
Everything related with properties is in PropertyHelper.
ProjectHelper delegates for backward compat.
I deprecated some of the methods, easy to revert if you think they
are needed.
21 lines of code changed in:
Everything related with properties is now in PropertyHelper.
Project delegates to PropertyHelper ( for backward compatibility ).
As soon as the API is stable ( i.e. do we pass ns ? Object ? )
we can deprecate the methods in Project.
27 lines of code changed in:
Same property helper, to allow porting of the plugins and to support
the same plugins in 1.5
The main focus of embed should be support for 1.5 for people
who can't upgrade to head.
628 lines of code changed in:
"Dynamic properties" and a bit more.
This is "slightly" different from embed - if dynamic properties will be
accepted in 1.6, it is better to do it right. Embed uses few hacks to
trick the ProjectHelper.
PropertyHelper includes all the code related with property manipulation
from Project (cut&paste). I added a very simple hook mechanism ( Filter/Valve
like ) for the most common operations.
The API is obviously far from final - someone who really understand "user"
and "inherited" properties should review it and make few changes.
In Project, all properties fields are private - so all can be removed.
The methods related with properties will just delegate to PropertyHelper.
From a user point of view - no visible change ( hopefully :-). Even grant
will continue to work ( but won't be able to use the new features ).
Benefits:
- cleanup of Project. Less code and better organised.
- Property handling will hopefully be cleaner too
- we get to add APIs for namespace support, and maybe support non-string
properties ( JSP-EL like - that needs to be disussed, but IMO it would
be very helpfull ). While refs are Objects, the main distinction is imutability.
Also:
- apps embeding or extending ant can fully customize _all_ aspects of
property processing, including ${} replacement and even the syntax.
- it should be very easy to hook a different storage mechanism ( i.e.
integrated with the embeding app, without requiring copy of properties ).
- it should be possible to avoid copy when creating execution frames
( by using a chain that keeps changes and delegates getters ).
- dynamic properties support ( my original itch :-)
Please wait few days before firing, it seems all tests are passing
and gump works - but I'm sure there are few problems :-)
( I'll commit the change in Project later today )
PR:
Obtained from:
Submitted by:
Reviewed by:
628 lines of code changed in:
*** empty log message ***
4 lines of code changed in:
Quick fail if ImportTask is used with a ProjectHelper that doesn't
support imports. The original helper won't work ( because of eval order ),
and embed will fail too ( since it can't use 1.6 features - one of the
goals is to work in ant1.5 ).
I'm ready to move the dynamic properties and the component hooks - I'll
porbably do it this weekend ( most people are in vacation, so fewer
will feel any breakage ). In any case [embed] should now used only
if you want to use (some) new features in ant1.5.
5 lines of code changed in:
Renamed PropertyHelper to PropertyHelper2, so it'll still compile with
ant1.6 after a PropertyHelper is added.
4 lines of code changed in:
Update with the 2 changes: set attributes explicitely ( instead of passing
the SAX2 Attributes).
- import will use the normal entry point and will not depend on the sax
context. We know we are in an import by looking at the importStack,
that will set ignoreProjectTag flag and we'll reuse the context.
There are few more changes needed to clean up the context ( some fields
are no longer needed, and it needs to use proper getter/setters instead
of the fields ).
25 lines of code changed in:
A change in ProjectHelper2 - RC doesn't need to depend on SAX2.
The attributes are just stored in a Hashtable, you can construct the
UE/RC tree without using any SAX at all.
I added @deprecated tags to the SAX1 attributes as well.
Also added a (harmless - I hope ) Serializable interface to RC, and
transient to the fields that don't need to be serialized.
PR:
Obtained from:
Submitted by:
Reviewed by:
53 lines of code changed in:
Add "importStack" that will allow import to keep track of loops.
If importStack has more than one element, ProjectHelper implementations
should know they are inside an import. This can also be used to
display more informative error messages ( i.e. the include path to
a file with errors ).
Removed the SAX2 Attributes and deprecate the SAX1 Attributes methods.
I made a small change to RuntimeConfigurable to make it less SAX-dependent,
ProjectHelper2 will just use a simple Hashtable and RC/ProjectHelper will
be SAX-independent ( except the deprecated methods ). This would allow
better programmatic use of ant and maybe a DOM ProjectHelper.
One interesting note: while SAX is faster, using DOM or caching the
UE/RC tree will greatly optimize <antCall>, where the same file
is parsed on each call.
PR:
Obtained from:
Submitted by:
Reviewed by:
35 lines of code changed in:
Add a new method to get an IntrospectionHelper.
If one already exists, it'll be returned.
The method will register itself for projectEnd notifications.
( this avoids multiple IH and listeners )
PR:
Obtained from:
Submitted by:
Reviewed by:
24 lines of code changed in:
Remove the dependency on ProjectHelper2.
We only need the import stack to avoid loops and some
mechanism to let let the helper know we're processing an import.
PR:
Obtained from:
Submitted by:
Reviewed by:
41 lines of code changed in:
Ant-Fake-Forrest proposal advancements:
Enable the "Active Link" funktionality by taking care, that XML title tag and project entry name match (just for the few docs, where this wasn't the case anyways)
adding html-version of LICESE
removing faq.vsl by moving that functionality to site.vsl
600 lines of code changed in:
Update output directory.
5193 lines of code changed in:
Enable the vsl's to generate Forrest-lookalike output.
385 lines of code changed in:
"Fake-Forrest" resources
0 lines of code changed in:
Additional "Fake-Forrest" resources, as they should rest in the source folder...
0 lines of code changed in:
Revert the change, it causes gump failures ( thanks Gump ! )
I can't reproduce the error yet ( my gump works fine ), but
most likely this is the cause of the errors ( classloader changes
couldn't affect anything not using <classloader>).
I'll apply again the patch from Nicola, without making more
changes.
29 lines of code changed in:
Use classpath instead of path.
Allow more convenient specification of the classpath.
PR:
Obtained from:
Submitted by:
Reviewed by:
27 lines of code changed in:
Make the basedir of each project available.
I added both ant.file.NAME and basedir.NAME, and cleaned up a bit
the code.
41 lines of code changed in:
Patch from Nicola. Add a property "ant.file.PROJECTNAME" to point to
the file from which this imported file was read.
3 lines of code changed in:
Use <classloader> instead of <systemLoader>
4 lines of code changed in:
Made the messages for loading with direct and reverse delegation different.
Added a small message to display the source of the class ( like the
verbose:class option )
PR:
Obtained from:
Submitted by:
Reviewed by:
4 lines of code changed in:
Add <classloader> and <import>
PR:
Obtained from:
Submitted by:
Reviewed by:
2 lines of code changed in:
Add the <classloader> task.
It'll create a new loader or add paths to an existing loader.
The main use is for the core loader - used to load ant regular
and optional tasks.
This is similar with embed, but 90% of the code is not needed for
ant1.6 ( due to the delayed task creation ).
For both import and classloader I changed the name of the class
so embed can still compile.
234 lines of code changed in:
<import> task.
This is almost the same as in embed, except few simplifications
and cleanups.
PR:
Obtained from:
Submitted by:
Reviewed by:
152 lines of code changed in:
A small build test for <classloader>
I don't know how this can be included in the junit tests
( at least the part that loads optional tasks ) since the
test env already includes most classes.
In order to test - you need to run this without junit.jar
in ant/lib and to pass the path to junit.jar
PR:
Obtained from:
Submitted by:
Reviewed by:
23 lines of code changed in:
Add 2 (small) test files for import.
I still need to add the .java file and add tests for the
more advanced features.
PR:
Obtained from:
Submitted by:
Reviewed by:
0 lines of code changed in:
Add maxmemory option to control memory of the jarsigner VM
revert sigfile to a String - does not make sense to be a File
Added a testcase with keystore for signjar
PR: 1284, 10754
Submitted by: Jonathan Keller
111 lines of code changed in:
update WHATSNEW
20 lines of code changed in:
cut and paste error fixup
3 lines of code changed in:
Minor formatting
1 lines of code changed in:
Update test code to account for the new dependency file
25 lines of code changed in:
Make the message more informative when a class cannot be loaded
due to a missing dependent class.
PR: 14806
Submitted by: David Jencks
4 lines of code changed in:
Remove incorrect check on the output file length
PR: 15568
Submitted by: Mike Schilling
14 lines of code changed in:
Add test cases for class fileset to pick up new dependency types
PR: 13273
Obtained from: Jesse
37 lines of code changed in:
fixing line ending screwup from previous commit
62 lines of code changed in:
fix missing filterchain in example
27 lines of code changed in:
Detect more class references, particularly the ones used to create
Class instances
Suggested by: Frank-Michael Moser
22 lines of code changed in:
Make sure random component of names is always purely numeric - no negative signs
PR: 15399
Submitted by: Rob Shafer
6 lines of code changed in:
Doc patch suggested by John Lindwall
8 lines of code changed in:
Fix for the lowercase problem. Sorry for the delay, I didn't have access to
email this weekend.
The code may still have a small problem - but the original had similar
issues. I'll try to move the fix in UE later this week.
I think getting to a consistent behavior is quite important - I wouldn't
mind having all elements converted to lowercase, and I don't remember
and design and explicit decision to have some lowercased and some not.
If you still see problems - switch back to the original PH.
23 lines of code changed in:
Testcase to test conformance to case sesnitivity rules for tasks
and nested elements
70 lines of code changed in:
getDescription() now computes the description ( on demand ) using
the tree.
If ProjectHelperImpl is used - no differences should be visible.
PR:
Obtained from:
Submitted by:
Reviewed by:
5 lines of code changed in:
Initial fix for description problems.
If the original ProjectHelperImpl will be used, things will
work as before.
If not - Description will look into each target and do
whatever it is supposed to do.
PR:
Obtained from:
Submitted by:
Reviewed by:
56 lines of code changed in:
Project stores the targets in a hashtable. There is no way to
retrieve the ordered list. This should eventually be included in
Project, but for now I added a small workaround in order to
support Description.
PR:
Obtained from:
Submitted by:
Reviewed by:
10 lines of code changed in:
Add accessor for the text content.
PR:
Obtained from:
Submitted by:
Reviewed by:
10 lines of code changed in:
Make it compile with HEAD.
After the change to ProjectHelper2, [embed] shouldn't be
used with ant1.6, only with ant1.5 as a mechanism to use the
new tasks and semantics with the stable branch.
The build file for Ant1.6 should be the same ( and work the same)
as the build file for ant1.5.1+embed.
This is not the case at the moment, because embed supports import
and few other features that are not yet in the main branch.
Import and the system loader can be supported now as regular tasks.
( preferably moved into HEAD, but they can work as an antlib )
Dynamic properties and ProjectComponentFactory still need to be
discussed and merged to HEAD ( or replaced with whatever gets
in the HEAD ).
1 lines of code changed in:
addConfiguredXXX was not working for TaskAdpater wrapped classes
6 lines of code changed in:
Add mac, unix and dos as alternatives for <fixcrlf>'s eol option.
Submitted by: Martin van den Bemt <mllist at mvdb dot net>
13 lines of code changed in:
IBM has decided that one runtime jar simply is not enough.
PR: 15289
Submitted by: Ville Skytt? <ville dot skytta at iki dot fi>
13 lines of code changed in:
Remove filter token. It doesn't make sense to have it here and hard
coded version numbers all over the place in the rest of the manual.
Submitted by: Daniel Rall <dlr at collab dot net>
1 lines of code changed in:
need to take care with anchors, now that those pages have a <base> tag
40 lines of code changed in:
Document changes necessary to deal with mirrors.
Still preliminary as there is no real consensus on how to deal with
old releases.
36 lines of code changed in:
Add a method to support configuration using SAX2 attributes.
Changed ( at least for few now ) the default helper to the SAX2
processor.
The original processor can still be used using the system property,
and we can revert if we have see problems.
Description4 still fails - I'll add try to fix it later, I
don't think it's a big show-stopper.
42 lines of code changed in:
Few changes merged from embed to support delayed evaluation.
All of them should be harmless if used with the original parser.
PR:
Obtained from:
Submitted by:
Reviewed by:
50 lines of code changed in:
Added support for SAX2 attributes.
This is merged from RuntimeConfigurable2 ( sorry for the indentation
changes ).
PR:
Obtained from:
Submitted by:
Reviewed by:
38 lines of code changed in:
This is the delayed-task creation helper. It's a clened-up
version of ProjectHelperImpl from embed, with all other extensions
removed. I also removed all code that supported the old eval
mode ( which reduced the size in 1/2 )
899 lines of code changed in:
Fix typo.
PR: 15243
Submitted by: Gus Heck
1 lines of code changed in:
Another try with delayed task Class creation and runtime replacement
of UE in refs.
Revert to 1.120 if any problem.
PR:
Obtained from:
Submitted by:
Reviewed by:
133 lines of code changed in:
Different test - it seems the field is no private, so it can't pass.
PR:
Obtained from:
Submitted by:
Reviewed by:
1 lines of code changed in:
Port some changes from the main branch ( now entity tests pass )
Since embed should run in ant1.5 - I duplicated some of the new
methods in ant16. If ProjectHelper2 will move to the main branch
this needs to be removed ( and some other stuff too )
PR:
Obtained from:
Submitted by:
Reviewed by:
149 lines of code changed in:
Add support for <base> to Velocity templates, will be needed by download pages sooner or later
59 lines of code changed in:
Another direct download link to remove
6 lines of code changed in:
Rumors say that absolute file: URLs on Windows need a third slash.
Get rid of some code duplication.
23 lines of code changed in:
Activate mirrors
831 lines of code changed in:
Typo
18 lines of code changed in:
sync contributors list with STATUS
367 lines of code changed in:
Update Info on "Ant kurz & gut"
137 lines of code changed in:
Add pointer to release notes and older release.
60 lines of code changed in:
remove catalogfiles from xmlcatalog
14 lines of code changed in:
Regenerate after Erik's patches
78 lines of code changed in:
Should have added the sources as well 8-)
2 lines of code changed in:
Add Ant Kurz & Gut.
44 lines of code changed in:
no longer 'coming soon'. its come. added some details of JDwA's contents also.
40 lines of code changed in:
added my bio
10 lines of code changed in:
Activate mirrors, merge Centipede description
150 lines of code changed in:
Experimenting with the download page(s)
254 lines of code changed in:
fix some typos
8 lines of code changed in:
Add support for Unix permissions to <zip> and friends, doing it the
Info-Zip way.
PR: 6492
250 lines of code changed in:
Simple STATUS File - needs a bit more info
64 lines of code changed in:
First cut at Ant bylaws. Nothing too strange here, I hope.
212 lines of code changed in:
Update description of Krysalis centipede.
Based on submission by: Nick Chalko <nick at chalko.com>
26 lines of code changed in:
test that we get the expected reference on java1.2, by a bit of convolution. (i.e that we dont get the 1.1 compatible ref)
49 lines of code changed in:
exposing the internal class for testing
1 lines of code changed in:
Roll back. I'll do more testing and try again...
32 lines of code changed in:
Another small improvement - if the 'coreLoader' is set, try
it before Class.forName().
AFAIK nobody sets it right now. The 'only' system property is
checked.
I'll wait for the gump runs to see if anything breaks and revert
the "lazy task creation" if it does.
PR:
Obtained from:
Submitted by:
Reviewed by:
10 lines of code changed in:
Few extra checks and small improvements to the delayed tasks
PR:
Obtained from:
Submitted by:
Reviewed by:
12 lines of code changed in:
2 small (?) changes.
References are stored in a special hashtable that automatically
configures UnknownElements. ( this will probably be a noop with
the current execution model most of the times - since ProjectHelper
already does that ).
Also task and type creation is delayed and not all tasks are
constructed. That should remove few seconds from the startup time,
and will simplify a lot of code that modifies the classpath at
runtime.
Please review - and if you see any problem -1 it. I checked it in
mostly to allow other people to verify the Script with lazy
eval. If there are objections I can turn this into a hook
and move it to [embed].
PR:
Obtained from:
Submitted by:
Reviewed by:
89 lines of code changed in:
Added a hashtable that allows delayed initialization.
In most build files you don't use _all_ tasks and types -
and it takes few second to process all exceptions due to class not
found ( for optional tasks ). This class will allow tasks to
be created when needed, and will also improve the behavior
when the main class loader is changed.
PR:
Obtained from:
Submitted by:
Reviewed by:
114 lines of code changed in:
Replace the UE with the task as soon as the task is constructed.
This allows Script tasks to work in most cases- and any other task that
requires Task in the tree.
It is the current behavior - but I think it is not the best solution.
6 lines of code changed in:
getting close to Info-Zip now, will enable it next week
50 lines of code changed in:
Some prelimnary commit for bug 6492 - I'm still trying to understand how Info-Zip stores the permissions
53 lines of code changed in:
forgot to add this
0 lines of code changed in:
merge mirror stuff from site
12 lines of code changed in:
Add download page by Justin Erenkrantz
0 lines of code changed in:
Add flesh to the contributors page
196 lines of code changed in:
Real tired of seeing email address being abused.
62 lines of code changed in:
The zip task doesn't work correctly if you're using filesetmanifest and update is false - Fix for this problem caused by previous patch.
Submitted by: Brian Deitte <bdeitte@macromedia.com>
11 lines of code changed in:
Modest contribution to help Stefan if he wants to test for Forrest.
I doubt this is complete and there should probably be some tweaks
to do as it will remove some br formatting (and I did not test yet under
Forrest, only from the top of my head). Not perfect, but this should
somewhat ease the conversion by doing most of the borring work.
cya
188 lines of code changed in:
Make ConcatTest work on non-Unix
3 lines of code changed in:
Actually test the resolver stuff of xmlcatalog
94 lines of code changed in:
Add download from mirror links
14 lines of code changed in:
Draft proposal for Ant's standalone website
4919 lines of code changed in:
Don't append a dot to package roots if there already is one.
4 lines of code changed in:
make XMLCatalog less verbose
12 lines of code changed in:
Add <catalogpath> to <xmlcatalog>.
PR: 14978
Submitted by: Jeff Turner <jefft at apache.org>
150 lines of code changed in:
Add pointer to Antenna.
Submitted by: Joerg Pleumann <joerg@pleumann.de>
Update information on JCSC.
Submitted by: Ralph Jocham <rjocham72@netscape.net>
112 lines of code changed in:
remove trailing dot
1 lines of code changed in:
because I had a pressing need to be find out which parser I was using on java1.4, and new all the code was a cut and paste away
99 lines of code changed in:
fixing alignment and reporting of .net app probe
6 lines of code changed in:
<vbc> docs
33 lines of code changed in:
<vbc> docs
194 lines of code changed in:
cleaning up something that looks like an incomplete tag otherwise
1 lines of code changed in:
